Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: TOP P5 Sigma Staff/Feet Call #5318

Merged
merged 10 commits into from
Apr 3, 2023
Merged

Conversation

Legends0
Copy link
Contributor

The logs seem a bit strange on this one. Omega-M which casts Discharge, is seen as casting the spell but Omega-F is what readies it. Unsure if this is capturing the correct npc model.

@Legends0
Copy link
Contributor Author

Last I tested this, it's throwing an 'error stopped' like message when the trigger activates in sigma but trigger actives fine on the p2 Discharger event. I am not quite sure what is causing the error. It's likely happening in either the promise or in the data.combatantData.pop() during runtime.

@quisquous
Copy link
Owner

Hmm. I don't think data.combatantData.pop() could go wrong unless data.combatant was undefined. "Error stopped" sounds a lot more like #5153, where the pull is over before the delayed trigger fires.

Legends0 and others added 3 commits March 30, 2023 14:27
Co-authored-by: Adrienne Walker <enne@quisquo.us>
confirmed through logs of WeaponID that this is the correct npc to use. Logs showed example timing of 5.7s, rounding to 6 for safety.
@Legends0 Legends0 marked this pull request as ready for review April 2, 2023 01:51
@Legends0
Copy link
Contributor Author

Legends0 commented Apr 2, 2023

I dropped the delay to 6.2, I swear I had tested with 6 on my part and it did not work, but it may work at 6.2 if others seeing it less than 6 from the ability going off in the log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants