Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: add TOP p5 near/far reminders #5319

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

quisquous
Copy link
Owner

No description provided.

@quisquous quisquous merged commit 43f47c4 into main Mar 28, 2023
@quisquous quisquous deleted the raidboss_top_p5_nearfar branch March 28, 2023 23:29
Comment on lines +1349 to +1353
return output.near!();
if (matches.effectId === 'D73')
return output.distant!();
},
outputStrings: nearDistantOutputStrings,
Copy link
Contributor

@Legends0 Legends0 Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run npx eslint against the file, I get errors on these lines:
1336:18 error no 'near' in 'output' rulesdir/cactbot-output-strings
1338:18 error no 'distant' in 'output' rulesdir/cactbot-output-strings

No errors seen in npm run start.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is weird. I do not see any lint errors locally or on the bot.

(What is npx eslint? There's no npm run eslint rule. There is npm lint?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant the npm start output does not show errors, but npx eslint on my ui/raidboss/data/06-ew/ultimate/the_omega_protocol.ts file with this trigger present produces its

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What command are you running to see this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from within my cactbot directory:
npx eslint ui\raidboss\data\06-ew\ultimate\the_omega_protocol.ts

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's weird. I never use that command, but running that does not show any errors for me. Is your repository up to date? There were some fixes to the output strings lint rules to improve this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it was something in my cactbot\eslint directory that was out of date. I replaced it with the latest and the error is gone now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants