-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raidboss: add TOP p5 near/far reminders #5319
Conversation
return output.near!(); | ||
if (matches.effectId === 'D73') | ||
return output.distant!(); | ||
}, | ||
outputStrings: nearDistantOutputStrings, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run npx eslint against the file, I get errors on these lines:
1336:18 error no 'near' in 'output' rulesdir/cactbot-output-strings
1338:18 error no 'distant' in 'output' rulesdir/cactbot-output-strings
No errors seen in npm run start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this is weird. I do not see any lint errors locally or on the bot.
(What is npx eslint
? There's no npm run eslint
rule. There is npm lint
?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant the npm start output does not show errors, but npx eslint on my ui/raidboss/data/06-ew/ultimate/the_omega_protocol.ts file with this trigger present produces its
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What command are you running to see this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from within my cactbot directory:
npx eslint ui\raidboss\data\06-ew\ultimate\the_omega_protocol.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that's weird. I never use that command, but running that does not show any errors for me. Is your repository up to date? There were some fixes to the output strings lint rules to improve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it was something in my cactbot\eslint directory that was out of date. I replaced it with the latest and the error is gone now.
No description provided.