raidboss: TOP P5 Omega Earlier Safe Spot Call #5330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an AddCombatants that occurs either before or shortly after the 8015 Run Dynamis: Omega Version cast starts. This utilizes OverlayPlugin, which the other two triggers still pull data from. Previous PR did not have delay and so did not fire if the combatants were added late per the log line. Alternatively, this trigger can fire off a collection of AddCombatants that match the NNPCIds, but some care would need to be accounted for if they happened to be added before the Omega Version cast starts since that is also what triggers the 'omega' phase. Basing on AddCombatants (if this line varies) could also make a durationSeconds more varied. So I have stuck with the 8015 cast for now and may test different delays.
quisquos discovered WeaponId is changing 2.66s after the ability.
|
Do you feel like this is good to land, or should I wait on merging? |
|
I think it's good enough to land. It can then be adjusted in #5334. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
There is an AddCombatants that occurs either before or shortly after the 8015 Run Dynamis: Omega Version cast starts. This utilizes OverlayPlugin, which the other two triggers still pull data from. Previous PR did not have delay and so did not fire if the combatants were added late per the log line. Alternatively, this trigger can fire off a collection of AddCombatants that match the BNPCIds, but some care would need to be accounted for if they happened to be added before the Omega Version cast starts since that is also what triggers the 'omega' phase. Basing on AddCombatants (if this line varies) could also make a durationSeconds more varied. So I have stuck with the 8015 cast for now and may test different delays. 6a131b8
github-actions bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
There is an AddCombatants that occurs either before or shortly after the 8015 Run Dynamis: Omega Version cast starts. This utilizes OverlayPlugin, which the other two triggers still pull data from. Previous PR did not have delay and so did not fire if the combatants were added late per the log line. Alternatively, this trigger can fire off a collection of AddCombatants that match the BNPCIds, but some care would need to be accounted for if they happened to be added before the Omega Version cast starts since that is also what triggers the 'omega' phase. Basing on AddCombatants (if this line varies) could also make a durationSeconds more varied. So I have stuck with the 8015 cast for now and may test different delays. 6a131b8
quisquous
added a commit
that referenced
this pull request
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an AddCombatants that occurs either before or shortly after the 8015 Run Dynamis: Omega Version cast starts. This utilizes OverlayPlugin, which the other two triggers still pull data from.
Previous PR did not have delay and so did not fire if the combatants were added late per the log line. Alternatively, this trigger can fire off a collection of AddCombatants that match the BNPCIds, but some care would need to be accounted for if they happened to be added before the Omega Version cast starts since that is also what triggers the 'omega' phase. Basing on AddCombatants (if this line varies) could also make a durationSeconds more varied. So I have stuck with the 8015 cast for now and may test different delays.