util: make_timeline - sort ignored combatants #5616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorts the ignored combatants list in `make_timeline.ts` for easier future maintenance. No entries added or removed.
|
Thanks, this was definitely getting unwieldy. I wonder if we need some better method of detecting npc combatants, recording their ids, and then removing them that way. |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2023
Sorts the ignored combatants list in `make_timeline.ts` for easier future maintenance. No entries added or removed. a405451
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jun 26, 2023
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jun 26, 2023
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jun 26, 2023
|
The Duty Support npcs are considered pets of the player, so a way to detect and exclude pets would automatically catch most of this list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorts the ignored combatants list in
make_timeline.tsfor easier future maintenance. No entries added or removed.