Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: minor Eureka Orthos additions/fixes #5645

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Conversation

quisquous
Copy link
Owner

No description provided.

@xiashtra
Copy link
Contributor

xiashtra commented Jul 5, 2023

Do you have a 6.4 log of floor 40? I suspect Twintania Clone was also renamed, to Twintania's Clone, and needs a similar update.

@quisquous
Copy link
Owner Author

Do you have a 6.4 log of floor 40? I suspect Twintania Clone was also renamed, to Twintania's Clone, and needs a similar update.

Oh! Good call. I guess I was too tired / focusing on mechanics to notice there weren't callouts there either. <_<

@Akurosia are there updated translations in other languages for these?

@Akurosia
Copy link
Contributor

Akurosia commented Jul 6, 2023

Sry currently not in reach of my pc. Will take a day or 2 to verify

@Akurosia
Copy link
Contributor

Akurosia commented Jul 8, 2023

Regarding Eureka Orthos i did not see any other changes (as far as i am aware of the enemy names) but i made a small repo with the files i use (from what i had left) so i compared 6.38 and 6.41 which you can find here: https://github.com/Akurosia/ffxiv_translate_json/compare/37d362b..c66ded8

I also noted some other changes which might affect other fights. And i dont really know if these are really used once or not as we do not have a list of bnpcid in the files itself to easy reference them.

Might be a thing we should considere in generall to use bnpc IDs instead of Names whereever posible (easier to maintain, less to translate)

@quisquous
Copy link
Owner Author

Might be a thing we should considere in generall to use bnpc IDs instead of Names whereever posible (easier to maintain, less to translate)

Unfortunately there's only bnpcid on the added combatant line but not on other lines. Other options here could be that the translation section could have a bnpcid -> name section (like the syncs, but just referenced differently) or alternatively alternatively we could consider dropping names from triggers (and timelines?)

@xiashtra
Copy link
Contributor

xiashtra commented Jul 8, 2023

Might be a thing we should considere in generall to use bnpc IDs instead of Names whereever posible (easier to maintain, less to translate)

Unfortunately there's only bnpcid on the added combatant line but not on other lines. Other options here could be that the translation section could have a bnpcid -> name section (like the syncs, but just referenced differently) or alternatively alternatively we could consider dropping names from triggers (and timelines?)

Or, we could get Ravahn to include the bnpcid on the other log lines like it should be 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants