Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: TOP add missing replaceSync #5649

Merged
merged 1 commit into from
Jul 6, 2023
Merged

raidboss: TOP add missing replaceSync #5649

merged 1 commit into from
Jul 6, 2023

Conversation

Souma-Sumire
Copy link
Contributor

No description provided.

@quisquous
Copy link
Owner

Are these all of the missing translations? It looks like missingTranslations: true is still set.

@Souma-Sumire
Copy link
Contributor Author

I'm not sure, but it appears that way.

Additional question: So should we remove missingTranslations when it's complete?
(I was unaware of the purpose of this property, as it only exists in the ja and fr branches in the main branch, and it doesn't exist in the cn and de branches. I don't understand the other languages, so I can't discern their differences.)

@quisquous
Copy link
Owner

Yes, definitely, remove it if unneeded.

If you run npm run util -- findTranslations -f . -l fr (or -l ja etc etc) it will show you all the missing translations for that language, including files where missingTranslations is set to true when not needed.

@Souma-Sumire
Copy link
Contributor Author

Thank you for the tutorial. After running the command, I see a lot of unresolved issues, and I believe this is a massive project that lacks long-term maintenance.

@xiashtra
Copy link
Contributor

xiashtra commented Jul 7, 2023

Thank you for the tutorial. After running the command, I see a lot of unresolved issues, and I believe this is a massive project that lacks long-term maintenance.

It's more an issue of lack of translators.

@quisquous
Copy link
Owner

I think there's a number of issues, for sure. I think visibility (as probably only a few people know that command at this point, and so don't understand which translations are missing) is definitely part of it. I'll look into adding the missing translations as part of the build process (maybe the coverage generator??) and so it will be much more obvious which fights are missing translations and where.

@quisquous
Copy link
Owner

#5657 should address some of this. I'll add to my list to write some better documentation for translators as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants