util: fix async bugs with find missing translations #5699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "code" missing translations finder wasn't properly async and so would continue to accumulate missing translations as the rest of the coverage report continued. The find missing translations script (standalone) handles this by not ending automatically, but the coverage report would (for example) list 4 entries but then say 21 errors as the the counting of the errors came after the entries were written.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 16, 2023
…5699) The "code" missing translations finder wasn't properly async and so would continue to accumulate missing translations as the rest of the coverage report continued. The find missing translations script (standalone) handles this by not ending automatically, but the coverage report would (for example) list 4 entries but then say 21 errors as the the counting of the errors came after the entries were written. 09e223b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "code" missing translations finder wasn't properly async and so would continue to accumulate missing translations as the rest of the coverage report continued.
The find missing translations script (standalone) handles this by not ending automatically, but the coverage report would (for example) list 4 entries but then say 21 errors as the the counting of the errors came after the entries were written.