raidboss: add simple call for classical concepts #5725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quisquous
reviewed
Jul 24, 2023
| @@ -294,7 +294,7 @@ const getHeadmarkerId = (data: Data, matches: NetMatches['HeadMarker']) => { | |||
| export interface Data extends RaidbossData { | |||
| readonly triggerSetConfig: { | |||
| engravement1DropTower: 'quadrant' | 'clockwise' | 'tower'; | |||
| classicalConceptsPairOrder: 'xsct' | 'cxts' | 'ctsx' | 'ctxs'; | |||
| classicalConceptsPairOrder: 'xsct' | 'cxts' | 'ctsx' | 'ctxs' | 'shapeAndDebuff'; | |||
There was a problem hiding this comment.
Sorry for one last comment, but can you make this the default? I think this is a better default than bpog.
There was a problem hiding this comment.
Sorry for one last comment, but can you make this the default? I think this is a better default than bpog.
😭
There was a problem hiding this comment.
Sorry! I think it's better to not make assumptions about strats if we can. I'll make a release note.
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jul 24, 2023
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jul 24, 2023
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.