oopsy: add isImmune to OopsyData #5750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quisquous
reviewed
Aug 5, 2023
types/data.d.ts
Outdated
| @@ -50,6 +50,7 @@ export interface OopsyData { | |||
| role: Role; | |||
| party: PartyTracker; | |||
| inCombat: boolean; | |||
| isImmune: (x?: string) => boolean; | |||
There was a problem hiding this comment.
Suggested change
| isImmune: (x?: string) => boolean; | |
| IsImmune: (x?: string) => boolean; |
I hate that past me made functions have capital letters in this class, but probably this should be consistent with the other functions here.
ui/oopsyraidsy/damage_tracker.ts
Outdated
| @@ -159,6 +159,12 @@ export class DamageTracker { | |||
| role: this.role, | |||
| party: this.playerStateTracker.partyTracker, | |||
| inCombat: this.inCombat, | |||
| isImmune: (targetId?: string) => { | |||
There was a problem hiding this comment.
Suggested change
| isImmune: (targetId?: string) => { | |
| IsImmune: (targetId?: string) => { |
| @@ -159,6 +159,12 @@ export class DamageTracker { | |||
| role: this.role, | |||
| party: this.playerStateTracker.partyTracker, | |||
| inCombat: this.inCombat, | |||
| isImmune: (targetId?: string) => { | |||
| const invulnIds = ['52', '199', '32A', '32B', '72C']; | |||
There was a problem hiding this comment.
Can you leave a comment as to what these all are? Mostly so that if/when one changes in the future it's easier to come and edit this.
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll look at actually making this work in p12s tomorrow. maybe.