raidboss: add named timeline jump labels #5760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mentioned in #5619.
|
A proof of concept. I think it's kind of nice to have labels on their own lines to make them more visually obvious even if it means repeating a timestamp. |
JLGarber
reviewed
Aug 14, 2023
|
I like this. A significant benefit I can see right away is that named jumps don't need to be updated alongside timeline adjustments. That will be really nice. |
Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com>
|
Leaving this open for another week in case anybody has more feedback here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned in #5619.