Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oopsy: fix P12N palladion spread id #5778

Merged
merged 1 commit into from
Sep 3, 2023
Merged

oopsy: fix P12N palladion spread id #5778

merged 1 commit into from
Sep 3, 2023

Conversation

g0shu
Copy link
Contributor

@g0shu g0shu commented Sep 3, 2023

82C3 is Trinity of Souls (line 14)

@github-actions github-actions bot added the oopsy label Sep 3, 2023
@g0shu
Copy link
Contributor Author

g0shu commented Sep 3, 2023

as a thought, should there be a test checking if the same ability is being warned about from 2 triggers? because something like is probably never an intended behavior
image

@g0shu g0shu changed the title oopsy: fixpalladion spread id oopsy: fix palladion spread id Sep 3, 2023
@quisquous quisquous changed the title oopsy: fix palladion spread id oopsy: fix P12N palladion spread id Sep 3, 2023
@quisquous
Copy link
Owner

as a thought, should there be a test checking if the same ability is being warned about from 2 triggers? because something like is probably never an intended behavior

Mmmmm yeah, that's a good thought.

@quisquous quisquous merged commit 39eb350 into quisquous:main Sep 3, 2023
github-actions bot pushed a commit that referenced this pull request Sep 3, 2023
@g0shu g0shu deleted the palladion-spread branch September 20, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants