plugin: disable strong name req for FFXIV_ACT_Plugin.Common #5806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Echoring Thanks for your contribution! 🌵🚀 |
Echoring
changed the title
MaikoTan
approved these changes
Sep 23, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2023
…Common (#5806) CN players use a modified FFXIV_ACT_Plugin to parse the game. (https://github.com/TundraWork/FFXIV_ACT_Plugin_CN) This modified plugin do not have strong name, so cactbot report an error like this: ``` [2023/9/23 15:22:11] Error: LoadAddons: CactbotOverlay.dll: System.IO.FileLoadException: Could not load file or assembly 'FFXIV_ACT_Plugin.Common, Version=2.2.0.5, Culture=neutral, PublicKeyToken=9f740ac505d6bc50' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044) File name: 'FFXIV_ACT_Plugin.Common, Version=2.2.0.5, Culture=neutral, PublicKeyToken=9f740ac505d6bc50' ---> System.IO.FileLoadException: A strongly-named assembly is required. (Exception from HRESULT: 0x80131044) at Cactbot.FFXIVPlugin.RegisterProcessChangedHandler(Action`1 handler) at Cactbot.CactbotEventSource.Start() at RainbowMage.OverlayPlugin.Registry.StartEventSource[T](T source) at RainbowMage.OverlayPlugin.PluginMain.LoadAddons() ``` I remove the strong name in `\plugin\ThirdParty\FFXIV_ACT\SDK\FFXIV_ACT_Plugin.Common.dll` and the config file is autoly changed like this. I rebuild the dll and the problem solved. I'm not familiar with .net and not sure does this fully handled by this option, if something amiss pray tell me. 86704dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CN players use a modified FFXIV_ACT_Plugin to parse the game. (https://github.com/TundraWork/FFXIV_ACT_Plugin_CN)
This modified plugin do not have strong name, so cactbot report an error like this:
I remove the strong name in
\plugin\ThirdParty\FFXIV_ACT\SDK\FFXIV_ACT_Plugin.Common.dlland the config file is autoly changed like this. I rebuild the dll and the problem solved.I'm not familiar with .net and not sure does this fully handled by this option, if something amiss pray tell me.