Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss/oopsy: Add Singularity Reactor Unreal #5831

Merged
merged 5 commits into from
Oct 6, 2023
Merged

raidboss/oopsy: Add Singularity Reactor Unreal #5831

merged 5 commits into from
Oct 6, 2023

Conversation

JLGarber
Copy link
Collaborator

@JLGarber JLGarber commented Oct 5, 2023

Updated sync_files with data sourced from FFLogs. The skill IDs line up, but some of the actors appear to have changed. Notably, the Comet and Heavy Impact abilities are now sourced from Thordan rather than various knights, and The Light Of Ascalon is also sourced by Thordan. I don't know whether this is an actual change to the encounter or an artifact of FFLogs/ACT needing updates.

This is fully untested in-game, and I won't have time until Friday, but here it is.

@JLGarber
Copy link
Collaborator Author

JLGarber commented Oct 5, 2023

I managed a single instance timer tonight that got to enrage. Timeline looks okay now that I fixed the broken sync. All the directional triggers are non-functional, so I'll look at that tomorrow.

@xiashtra
Copy link
Contributor

xiashtra commented Oct 5, 2023

I managed a single instance timer tonight that got to enrage. Timeline looks okay now that I fixed the broken sync. All the directional triggers are non-functional, so I'll look at that tomorrow.

There's a log with some more enrage pulls posted in the ACT_FFXIV Discord also.

@JLGarber JLGarber marked this pull request as ready for review October 6, 2023 00:01
@JLGarber
Copy link
Collaborator Author

JLGarber commented Oct 6, 2023

Thanks for contributing that, it was helpful. I've corrected the abilities that were not just a simple offset from the EX version and I think it should be good now.

I haven't yet tested the revision in-game, but test_timeline shows nothing obviously broken, and no triggers are actively wrong that I can see. I think this should be okay for release and we can fix any missing triggers later.

@quisquous quisquous merged commit a702f26 into quisquous:main Oct 6, 2023
github-actions bot pushed a commit that referenced this pull request Oct 6, 2023
Updated sync_files with data sourced from FFLogs. The skill IDs line up,
but some of the actors appear to have changed. Notably, the Comet and
Heavy Impact abilities are now sourced from Thordan rather than various
knights, and The Light Of Ascalon is also sourced by Thordan. I don't
know whether this is an actual change to the encounter or an artifact of
FFLogs/ACT needing updates.

This is fully untested in-game, and I won't have time until Friday, but
here it is. a702f26
github-actions bot pushed a commit that referenced this pull request Oct 6, 2023
Updated sync_files with data sourced from FFLogs. The skill IDs line up,
but some of the actors appear to have changed. Notably, the Comet and
Heavy Impact abilities are now sourced from Thordan rather than various
knights, and The Light Of Ascalon is also sourced by Thordan. I don't
know whether this is an actual change to the encounter or an artifact of
FFLogs/ACT needing updates.

This is fully untested in-game, and I won't have time until Friday, but
here it is. a702f26
@JLGarber JLGarber deleted the update-thordan-unreal branch October 22, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants