raidboss: Add 263/264 line types #5896
Conversation
|
|
||
| This line contains extra data for ActorCast/StartsUsing network data. | ||
|
|
||
| This line is always output for a given StartsUsing cast. If the ability does not target the |
There was a problem hiding this comment.
This is a belated thought for the OP patch, but I wonder if it'd be better if this line always printed the source position and then also included the target data if it existed (maybe with flags here too, if they exist). Mostly just saying that there's a lot of "figure out where things are when they start casting" that would benefit from always having the source actor position. (cc @xpdota too)
There was a problem hiding this comment.
Wouldn't it have the same issue as the native 20/21/22 lines, where a position read from memory might be stale?
There was a problem hiding this comment.
I think the hope was that it would have actor position data in the network packet as well, but I don't think that's the case?
There was a problem hiding this comment.
Yeah, that was my hope. I guess if it doesn't have it, then it doesn't have it.
There was a problem hiding this comment.
I think the only true solution for cast-before-move race conditions - without modifying the base plugin - is to hook ActorMove (and anything else that could move an actor), and have that data take priority over memory in 261-lines.
Add the new line types, and their corresponding documentation. I don't think I missed anything here but please double check as the info included in LogGuide.md may be excessive or not 100% accurate for all cases. ebe47e9
Add the new line types, and their corresponding documentation. I don't think I missed anything here but please double check as the info included in LogGuide.md may be excessive or not 100% accurate for all cases. ebe47e9
Add the new line types, and their corresponding documentation.
I don't think I missed anything here but please double check as the info included in LogGuide.md may be excessive or not 100% accurate for all cases.