oopsy: update oopsy code to use player objects #5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup to #5861. There's no "output strings" in oopsy, but it does use ShortName in a few places. Move this over to data.party.member(x).toString() in order to potentially support an oopsy option for how to display names. This also changes some logic for mit tracking and raise tracking to use full names instead of short names when storing and comparing, only using the shortened version for output. This also creates the party tracker earlier so that it can be passed to all the things that want to use it, and so all of oopsy can indirect through `PartyTracker` to find out short names.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
Followup to #5861. There's no "output strings" in oopsy, but it does use ShortName in a few places. Move this over to data.party.member(x).toString() in order to potentially support an oopsy option for how to display names. This also changes some logic for mit tracking and raise tracking to use full names instead of short names when storing and comparing, only using the shortened version for output. This also creates the party tracker earlier so that it can be passed to all the things that want to use it, and so all of oopsy can indirect through `PartyTracker` to find out short names. 2cc271d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5861.
There's no "output strings" in oopsy, but it does use ShortName in a few places. Move this over to data.party.member(x).toString() in order to potentially support an oopsy option for how to display names.
This also changes some logic for mit tracking and raise tracking to use full names instead of short names when storing and comparing, only using the shortened version for output.
This also creates the party tracker earlier so that it can be passed to all the things that want to use it, and so all of oopsy can indirect through
PartyTrackerto find out short names.