Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raidboss/test: improve testing of timeline netregex #5968

Merged
merged 2 commits into from
Dec 1, 2023
Merged

raidboss/test: improve testing of timeline netregex #5968

merged 2 commits into from
Dec 1, 2023

Commits on Dec 1, 2023

  1. raidboss/test: improve testing of timeline netregex 

    This is a follow-up to #5962, which itself is related to #5939.

I forgot that `find_missing_timeline_translations.ts` is only half
of the testing picture and `test_timeline.ts` needed to be updated
too. This was found by trying to test more lines and having test
timeline complain that InCombat regex lines were not translated.
    @quisquous
    quisquous committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ca524f9 View commit details
    Browse the repository at this point in the history

  2. also fix seal test

    @quisquous
    quisquous committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    da42236 View commit details
    Browse the repository at this point in the history