raidboss: normalize timelines in preparation for conversion #5975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
quisquous
commented
Dec 2, 2023
quisquous
commented
- Various sync fixes where it is clearly broken.
- Various sync massaging to look like other syncs.
- Break apart any (source1:id1|source2:id2) into (source1|source2):(id1:id2)
- Adjust LakshmiEx timeline to avoid sync /.*/ by adding filler.
quisquous
force-pushed
the
timeline_normalize
branch
from
4d9005e
to
da8c2f7
Compare
- Various sync fixes where it is clearly broken. - Various sync massaging to look like other syncs. - Break apart any (source1:id1|source2:id2) into (source1|source2):(id1:id2) - Adjust LakshmiEx timeline to avoid sync /.*/ by adding filler.
quisquous
force-pushed
the
timeline_normalize
branch
from
da8c2f7
to
dbac183
Compare
JLGarber
approved these changes
Dec 2, 2023
Comment on lines
+12
to
+22
| 7.5 "Fluid Swing" sync / 1[56]:[^:]*:Living Liquid:12EE:/ | ||
| 11.6 "Splash x3" duration 3 #sync / 1[56]:[^:]*:Living Liquid:12EF:/ | ||
| 19.9 "Protean Wave" sync / 1[56]:[^:]*:Living Liquid:12F0:/ | ||
| 23.5 "Fluid Swing" sync / 1[56]:[^:]*:Living Liquid:12EE:/ | ||
| 27.6 "Splash x3" duration 3 #sync / 1[56]:[^:]*:Living Liquid:12EF:/ | ||
| 32.9 "Fluid Swing" sync / 1[56]:[^:]*:Living Liquid:12EE:/ | ||
| 39.0 "Sluice" sync / 1[56]:[^:]*:Living Liquid:12F2:/ | ||
| 42.0 "--sync--" sync / 1[56]:[^:]*:Living Liquid:12F3:/ | ||
| 44.0 "--sync--" sync / 1[56]:[^:]*:Living Liquid:12F4:/ | ||
| 47.2 "Fluid Swing" sync / 1[56]:[^:]*:Living Liquid:12EE:/ | ||
| 53.3 "Splash x3" duration 3 #sync / 1[56]:[^:]*:Living Liquid:12EF:/ |
There was a problem hiding this comment.
I'm genuinely surprised these weren't correct at the time. I updated make_timeline something like two weeks before this was merged!
| 936.2 "Chorus Of The Lost" sync / 1[56]:[^:]*:416C:Hades:/ | ||
| 936.2 "Chorus Of The Lost" sync / 1[56]:[^:]*:Hades:416C:/ |
There was a problem hiding this comment.
Same situation here, I think this should be 14: etc.
There was a problem hiding this comment.
I think this one seems unlikely, as there is a 14 line at 906.5, and 906.5/936.2 parallels the later 1068.5/1098.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.