The Vault--Added triggers and timelines #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quisquous
reviewed
Oct 7, 2019
| }, | ||
| }, | ||
| { | ||
| id: 'The Vault Altar Candle', |
There was a problem hiding this comment.
Yay! This will be so nice to finally have better timings for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the pain that was Fractal Continuum, this was amazingly simple. Everything matches up nicely and I had no issues putting this together.
The inconsistent timings on tank busters vs AoE are to avoid unfortunate overlaps on mechanics. If everything were set to 5 seconds, it could be easy for users to assume that one popup was meant for a different mechanic, if they just go by sounds. The timings are adjusted to account for this as much as possible.
The one thing that could be added would be a popup to tell the user to try to overlap Hyperdimensional Slashes on Grinnaux. I couldn't think of a concise enough way to put it, and it would be spammy because he doesn't target these at a player. Perhaps later on when I feel like doing the math to determine his facing relative to player positions. (Obviously it's possible, since you do something similar for bomb boulder triggers in E4s, and facing is available also.)
Grinnaux's rotation isn't exact, because Dimensional Collapse appears to be on a slightly offset timer relative to the rest of his rotation. However, what I've done here is close enough, and it would take about 7 minutes of combat to desync to the point where it's noticeable. I don't think this will be an issue for the Vault.
Charibert's intermission is messier than I would like, but it's functional as it is. It's vastly unlikely that a party that can't clear the intermission would survive the enrage, so I didn't put too much effort into handling that. (The enrage is "soft" in the sense that it's not an automatic wipe; instead each flame that wasn't destroyed explodes for high damage.) Pure of Heart is used to close the intermission whether or not the flames are destroyed, so if it's used before the enrage time, I had the timeline jump to resume the rotation. Suggestions for better handling here are welcome.