forked from magento/magento2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Use the new json serializer which throws an error when failing #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ducts when Display Out of Stock Products enabled
[TSG-CSL3] For 2.2 (pr14)
[TSG] MFTF for 2.2 (pr11) (2.2.8)
…s should be skipped
…s should be skipped
…s should be skipped
[TSG] Backporting for 2.2 (pr64) (2.2.8)
…rns page. magento#20080 - Merge Pull Request magento#20080 from shikhamis11/magento2:2.2-develop-PR-port-19784 - Merged commits: 1. 9480a63
…ption email after registering for new account - Update status method fix - Unit test fix
…uick Search when more than one value is selected
… Value for 'product_type' attribute contains incorrect value magento#20081
…pping in shipping address label whenever any user adding new shipping address in mobile view in checkout magento#20083
…ls because of bad design - MFTF test fix
[EngCom] Public Pull Requests - 2.2-develop
…ls because of bad design - MFTF test fix
[TSG] Backporting for 2.2 (pr68) (2.2)
code formatting Backwards compatibility fix use JSON_HEX_TAG option for not breaking things use new serializer instead of json_encode use correct serializer in test declare return type use serializer updated unit testing, now uses serializer removed space declare strict type improved comment Test new serializer Test for greater than and lesser than symbol, required by JSON_HEX_TAG option split comment for readability Declare strict type on test Use di to inject cleanup curly brackets code cleanup removed empty phpdoc Fix BC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#16154
Description
Use the new serializer which throws an error when json_encoding fails.
Fixed Issues (if relevant)
Contribution checklist