Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Use the new json serializer which throws an error when failing #3

Closed
wants to merge 9,433 commits into from

Conversation

quisse
Copy link
Owner

@quisse quisse commented Jan 14, 2019

Original Pull Request

magento#16154

Description

Use the new serializer which throws an error when json_encoding fails.

Fixed Issues (if relevant)

  1. Javascript error thrown from uiComponent 'notification_area' if messages are malformed magento/magento2#14937: Javascript error thrown from uiComponent 'notification_area' if messages are malformed
  2. Perhaps more

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Your Name and others added 30 commits December 18, 2018 09:11
…ducts when Display Out of Stock Products enabled
[TSG] Backporting for 2.2 (pr64) (2.2.8)
magento-engcom-team and others added 29 commits January 5, 2019 06:26
…rns page. magento#20080

 - Merge Pull Request magento#20080 from shikhamis11/magento2:2.2-develop-PR-port-19784
 - Merged commits:
   1. 9480a63
…ption email after registering for new account

- Update status method fix

- Unit test fix
…uick Search when more than one value is selected
… Value for 'product_type' attribute contains incorrect value magento#20081
…pping in shipping address label whenever any user adding new shipping address in mobile view in checkout magento#20083
[EngCom] Public Pull Requests - 2.2-develop
code formatting

Backwards compatibility fix

use JSON_HEX_TAG option for not breaking things

use new serializer instead of json_encode

use correct serializer in test

declare return type

use serializer

updated unit testing, now uses serializer

removed space

declare strict type

improved comment

Test new serializer

Test for greater than and lesser than symbol, required by JSON_HEX_TAG option

split comment for readability

Declare strict type on test

Use di to inject

cleanup curly brackets

code cleanup

removed empty phpdoc

Fix BC
@quisse quisse closed this Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.