Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUnit 2.11+ leaks incomplete "Map" in older browsers #1508

Closed
Krinkle opened this issue Nov 15, 2020 · 0 comments · Fixed by #1509
Closed

QUnit 2.11+ leaks incomplete "Map" in older browsers #1508

Krinkle opened this issue Nov 15, 2020 · 0 comments · Fixed by #1509
Assignees
@Krinkle
Labels
Type: Bug Something isn't working right.

Comments

@Krinkle
Copy link
Member

Krinkle commented Nov 15, 2020

When upgrading QUnit in https://github.com/jashkenas/underscore I noticed that its unit tests for "is Map" started failing in older browsers because it was passing the check for "browser has Map support" but failing some of its tests since it is not actually a drop-in feature-complete implementation of ES6 Map.

I've submitted an upstream patch at farzher/fuzzysort#71 (farzher/fuzzysort#72), but meanwhile we should fix it so that we don't leak it.
@Krinkle Krinkle added the Type: Bug Something isn't working right. label Nov 15, 2020
@Krinkle Krinkle self-assigned this Nov 15, 2020
Krinkle added a commit that referenced this issue Nov 15, 2020
@Krinkle
HTML Reporter: Avoid leaking 'Map' in older browsers
1a2d37b 
On IE6-8 and in PhantomJS, our partial ES6 Map implementation
was leaking as global variable.

Follows 2f2eaba.
Fixes #1508.
@Krinkle Krinkle mentioned this issue Nov 15, 2020
Merged
Krinkle added a commit that referenced this issue Nov 15, 2020
@Krinkle
HTML Reporter: Avoid leaking 'Map' in older browsers
259f9af 
On IE6-8 and in PhantomJS, our partial ES6 Map implementation
was leaking as global variable.

Follows 2f2eaba.
Fixes #1508.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Krinkle Krinkle

Labels
Type: Bug Something isn't working right.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HTML Reporter: Avoid leaking Map variable in older browsers qunitjs/qunit
1 participant
@Krinkle