Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: accept a module flag/other flags #1680

Closed
ShaMan123 opened this issue Mar 17, 2022 · 1 comment
Closed

cli: accept a module flag/other flags #1680

ShaMan123 opened this issue Mar 17, 2022 · 1 comment
Assignees
@ShaMan123
Labels
Component: CLI Type: Enhancement New idea or feature request.

Comments

@ShaMan123
Copy link
Contributor

Another thing is that the cli should accept a module flag and set QUnit.config.module to the passed value
It's an easy fix, I would PR but I don't understand where the file is located.

Originally posted by @ShaMan123 in #1671 (comment)

If I'm right this should be an easy fix:

qunit/src/cli/run.js

Line 27 in e91441e

if ( options.filter ) {

@Krinkle Krinkle added Type: Enhancement New idea or feature request. Component: CLI labels Mar 17, 2022
@Krinkle Krinkle mentioned this issue Apr 18, 2022
Closed
@Krinkle
Copy link
Member

Krinkle commented Apr 22, 2022

Closed by 924e022.

@Krinkle Krinkle closed this as completed Apr 22, 2022
@Krinkle Krinkle mentioned this issue Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShaMan123 ShaMan123

Labels
Component: CLI Type: Enhancement New idea or feature request.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): module option ShaMan123/qunit
2 participants
@Krinkle @ShaMan123