Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): module option #1681

Closed
wants to merge 3 commits into from
Closed

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Mar 17, 2022

I don't understand where and how to add a test.

Fixes #1680.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 17, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ShaMan123 / name: Shachar (5dc9d2d)

@ShaMan123
Copy link
Contributor Author

It works now

@Krinkle
Copy link
Member

Krinkle commented Apr 9, 2022

Thanks @ShaMan123! I'll get this in the next release. I can add a test for you, but you're also welcome to give it a try first.

For this, I'd recommend adding a file under /test/cli/fixtures/<myfile>.js in which you define a few modules and some tests in the same file. Then run it with bin/qunit.js --module ... test/cli/fixtures/.... to see that it works. Add the output to fixtures/expected/tap-outputs.js and define the case in test/cli/cli-main.js.

To run the tests locally: npm run build (once) then npm run test-cli. Or simply npm test which will build and run all tests.

@Krinkle Krinkle self-assigned this Apr 18, 2022
@Krinkle
Copy link
Member

Krinkle commented Apr 21, 2022

I've assigned this to me to rebase and add tests. I did push out a patch release, but this'll be in the next minor in a few days.

@Krinkle
Copy link
Member

Krinkle commented Apr 22, 2022

Merged with 924e022.

@Krinkle Krinkle closed this Apr 22, 2022
@ShaMan123 ShaMan123 deleted the cli-module-option branch April 23, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

cli: accept a module flag/other flags
2 participants