Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: New test reporter hook. #1480

Closed
wants to merge 1 commit into from
Closed

Test: New test reporter hook. #1480

wants to merge 1 commit into from

Conversation

ventuno
Copy link
Member

@ventuno ventuno commented Sep 4, 2020

Attempt at: #1475.

@ventuno ventuno mentioned this pull request Sep 4, 2020
Open
Krinkle
Krinkle requested changes Oct 3, 2020
View reviewed changes
Copy link
Member

@Krinkle Krinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support the use case, but log events should imho not be allowed to see or influence runtime behaviour.

I think the same would also imply that it runs before testEnd but after the after* hooks.

Let's discuss further on #1475.

Base automatically changed from master to main March 18, 2021 18:59
@ventuno ventuno closed this Mar 19, 2021
@ventuno ventuno deleted the ftr-1475 branch March 19, 2021 14:23
@ventuno ventuno restored the ftr-1475 branch March 19, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krinkle Krinkle Krinkle requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ventuno @Krinkle