Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Upgrade tiny-glob to 0.2.8 #1523

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Build: Upgrade tiny-glob to 0.2.8 #1523

merged 1 commit into from
Dec 3, 2020

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Nov 30, 2020

Ref #1522.

Verify publication: tiny-glob 0.2.6 -> 0.2.8

$ npm info tiny-glob@0.2.8

dependencies:
- globalyzer: 0.1.0
- globrex: ^0.1.2  

maintainers:
- terkelg <terkel@terkel.com>

published a week ago by terkelg <terkel@terkel.com>

✅ It was published by the same account as previously.
✅ No new maintainers were added.
✅ No new dependencies were added.
⚠️ Some dependency versions changed:

-        "globalyzer": "^0.1.0" -> 0.1.4
+        "globalyzer": "0.1.0" -> 0.1.0
-        "globrex": "^0.1.1" -> 0.1.1
+        "globrex": "^0.1.2" -> 0.1.2

Verify publication: globalyzer 0.1.4 -> 0.1.0 (downgrade)

$ npm info globalyzer@0.1.0

globalyzer@0.1.0

maintainers:
- terkelg <terkel@terkel.com>

published over a year ago by terkelg <terkel@terkel.com>

✅ It was published by the same account as previously.
✅ No new maintainers were added.
✅ No new dependencies were added.
✅ No dependency versions changed.

Verify publication: globrex 0.1.1 -> 0.1.2

globrex@0.1.2 

maintainers:
- terkelg <terkel@terkel.com>

published a year ago by terkelg <terkel@terkel.com>

✅ It was published by the same account as previously.
✅ No new maintainers were added.
✅ No new dependencies were added.
✅ No dependency versions changed.

Review package diff: globalyzer 0.1.4 -> 0.1.0 (downgrade)

https://diff.intrinsic.com/globalyzer/0.1.0/0.1.4 (inverse!)

  • Effectively reverts away use of path.normalize(), and going back to using os.platform(). Upstream mentions that this change caused an issue in their tests, although we didn't run into it, and thus reverts for now. Ref terkelg/tiny-glob@7e61029

LGTM.

Review package diff: globrex 0.1.1 -> 0.1.2

https://diff.intrinsic.com/globrex/0.1.1/0.1.2

  • No code was added or changed.

Review package diff: tiny-glob 0.2.6 -> 0.2.8

https://diff.intrinsic.com/tiny-glob/0.2.6/0.2.8

  • Minor style changes.
  • Added TypeScript declaration file.
  • Changes to internal logic.

LGTM.

@Krinkle Krinkle closed this Dec 2, 2020
@Krinkle Krinkle reopened this Dec 2, 2020
@Krinkle Krinkle merged commit 25f8669 into master Dec 3, 2020
@Krinkle Krinkle deleted the upstream branch December 3, 2020 03:54
Krinkle added a commit that referenced this pull request Sep 5, 2021
Trivial update, only changed package metadata
<https://diff.intrinsic.com/tiny-glob/0.2.8/0.2.9>.

Ref #1523.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant