Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Reporter: Fix reversed order after clicking "Hide passed" #1763

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Commits on Jun 12, 2024

  1. HTML Reporter: Fix reversed order after clicking "Hide passed"

    Follows-up #1311.
    
    Since QUnit 2.7.0, when viewing a finished test run and turning on
    "Hide passed" and then turning it off again, resulted in the same
    results being shown again, but in reversed order.
    
    This was because we hide the tests from top to bottom (and push into
    the array), but then upon re-inserting them we used pop(), which means
    we first append the last test to the end of the page, but then the
    before-last is popped after that and appended to what is now the end
    of the page, etc. The end result is the tests first displaying from
    A-Z, then after toggling on/off, displaying from Z-A.
    Krinkle committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9e4c649 View commit details
    Browse the repository at this point in the history