Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken build starting with kernel 6.10 #30

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

craigcabrey
Copy link
Contributor

This fixes the build for kernel 6.10. Also seems to continue building for 6.9, but didn't check any earlier versions. I also didn't find if/where deprecation of those symbols occurred.

Let me know if there is a better way to do this.

@craigcabrey craigcabrey force-pushed the craigcabrey/fix-6.10 branch from 31f6af9 to 42057e4 Compare June 26, 2024 04:18
@quo
Copy link
Owner

quo commented Jun 26, 2024

Thanks!
According to torvalds/linux@957961b though, we should not manually add groups during probe. Using driver.dev_groups instead would be better. (Or should the attributes only be added after they have been given valid values? But that happens during probe...)

Thinking about it some more, I think we can just remove the attributes altogether. Vendor and product are redundant with various hid/input sysfs files. And I suspect no one cares about the product revision.

@quo quo merged commit e776647 into quo:master Jun 28, 2024
@quo
Copy link
Owner

quo commented Jun 28, 2024

Decided to remove the attrs (78e770b), and merged your other 6.10 fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants