Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cluster-autoscaler 1.30.x yaml status #297

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

antonincms
Copy link
Collaborator

  • Select status format depending on the clusterautoscaler-status-legacy-format flag
  • Update tests and usage to use cluster-autoscaler native types instead of internal ones
  • Remove LongNotStarted from the API and parsing

@antonincms antonincms force-pushed the cluster-autoscaler-yaml-status branch from 3372223 to 8165125 Compare August 2, 2024 07:57
@antonincms antonincms requested a review from a team August 2, 2024 08:06
@antonincms antonincms force-pushed the cluster-autoscaler-yaml-status branch 3 times, most recently from 85a8723 to 5364b7c Compare August 2, 2024 10:16
vincentmrg
vincentmrg previously approved these changes Aug 2, 2024
@antonincms antonincms force-pushed the cluster-autoscaler-yaml-status branch 3 times, most recently from 57eb809 to 1a29237 Compare August 2, 2024 11:47
Since the yaml version of the configmap is the future proof, and directly imported from cluster-autoscaler sources, this change makes it first class citizen.
@antonincms antonincms force-pushed the cluster-autoscaler-yaml-status branch from 1a29237 to 766944d Compare August 2, 2024 11:49
vincentmrg
vincentmrg previously approved these changes Aug 2, 2024
@antonincms antonincms merged commit 2d8cd56 into main Aug 2, 2024
3 checks passed
@antonincms antonincms deleted the cluster-autoscaler-yaml-status branch August 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants