BaseJob: Treat M_CONSENT_NOT_GIVEN separately from other content acce…

…ss errors Closes #207.
quotient-im · May 29, 2018 · c55c1cc · c55c1cc
1 parent e58a03c
commit c55c1cc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/jobs/basejob.cpp b/lib/jobs/basejob.cpp
@@ -313,7 +313,15 @@ void BaseJob::gotReply()
                 emit retryScheduled(d->retriesTaken, retryInterval);
                 return;
             }
-            if (!json.isEmpty())
+            if (json.value("errcode").toString() == "M_CONSENT_NOT_GIVEN")
+            {
+                auto urlString = json.value("consent_uri").toString();
+                setStatus(UserConsentRequiredError,
+                    tr("You must agree with the server's privacy policy; "
+                       "please visit %1").arg(urlString));
+                d->errorUrl = urlString;
+            }
+            if (!json.isEmpty()) // FIXME: The below is not localisable
                 setStatus(IncorrectRequestError, json.value("error").toString());
         }
     }
@@ -414,7 +422,7 @@ BaseJob::Status BaseJob::parseReply(QNetworkReply* reply)
     if( error.error == QJsonParseError::NoError )
         return parseJson(json);
     else
-        return { JsonParseError, error.errorString() };
+        return { IncorrectResponseError, error.errorString() };
 }
 
 BaseJob::Status BaseJob::parseJson(const QJsonDocument&)

diff --git a/lib/jobs/basejob.h b/lib/jobs/basejob.h
@@ -65,6 +65,7 @@ namespace QMatrixClient
                 , TooManyRequestsError
                 , RequestNotImplementedError
                 , NetworkAuthRequiredError
+                , UserConsentRequiredError
                 , UserDefinedError = 200
             };