Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][UX Improvement]: Tooltip/Word-Popover in darkmode color contrast #2145

Open
1 task done
Osama-ML opened this issue Apr 22, 2024 · 1 comment
Open
1 task done

Comments

@Osama-ML
Copy link

Is there an existing issue for this feature?

  • There is no exsiting issue for this feature

Summary

Asalamu3aikum

When you are reading some surat with the tab "Reading" and click in a word, and the tooltip/word-popover shows, in light te box-shadow is very useful to see the shape of the box
image

But in Darkmode its difficult:
image

Your purposed solution for this feature

I have two suggestions

  1. Change the div background and the svg fill colors in darkmode

image

  1. Change box-shadow color in darkmode

image

@Osama-ML Osama-ML changed the title [feature]: Tooltip/Word-Popover in darkmode color contrast [feature][UX Improvement]: Tooltip/Word-Popover in darkmode color contrast Apr 22, 2024
@IlijazM
Copy link

IlijazM commented May 2, 2024

Alejkum Salam. I personally agree and I like the redesign in the first picture. It makes it easier for the eyes to recognize the popover and it would increase the accessibility of it, I love to see that implemented.

The box shadow in the second image however is not recommended in most style guidelines. A dark shadow would be a too low contrast on the background in dark mode and a light glow doesn't give the impression of elevation and just looks off. Here are some resources about this topic:

https://m2.material.io/design/color/dark-theme.html
https://medium.com/@tundehercules/designing-effective-dark-mode-interfaces-17f38ecea2e9

mouhamaddev added a commit to mouhamaddev/quran.com-frontend-next that referenced this issue Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants