Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

"Previous/Next Surah" when reading first/last surah. #398

Closed
srifqi opened this issue Jul 11, 2016 · 6 comments · Fixed by #412
Closed

"Previous/Next Surah" when reading first/last surah. #398

srifqi opened this issue Jul 11, 2016 · 6 comments · Fixed by #412

Comments

@srifqi
Copy link

srifqi commented Jul 11, 2016

If you tried to click on Previous Surah while reading Surah Al-Fatihah or to click on Next Surah while reading Surah An-Nas, you will get message:

Surah is out of range. Please go to thehome page and select a Surah/Ayah

Can we hide/disable that button?

The location of the button:
previous surah button in Al-Fatihah

@srifqi srifqi changed the title Disable "Previous/Next Surah" when show first/last surah. "Previous/Next Surah" when reading first/last surah. Jul 11, 2016
@thabti
Copy link
Contributor

thabti commented Jul 11, 2016

@srifqi can you provide screenshots? I am not seeing previous or next on either of those surahs.

@srifqi
Copy link
Author

srifqi commented Jul 12, 2016

@sabeurthabti I've uploaded the screenshot in the first comment.

@mmahalwy
Copy link
Contributor

@sabeurthabti @srifqi i can replicate this behavior. Not sure why this is happening but we can put a fix for it inshallah.

@srifqi
Copy link
Author

srifqi commented Jul 12, 2016

@mmahalwy Thank you for your fast response. Don't forget to hide/disable "Next Surah" in An-Nas. 😄

@thabti
Copy link
Contributor

thabti commented Jul 12, 2016

@mmahalwy @srifqi I was looking at the bottom of the surah :(

@mmahalwy
Copy link
Contributor

Yeah, I think what we can do is just not call the function in the onClick callback. That's the quickest fix, cause from a UI it looks disabled but not from a functional point :)

@srifqi my pleasure :)

thabti added a commit to thabti/quran.com-frontend that referenced this issue Jul 19, 2016
thabti added a commit to thabti/quran.com-frontend that referenced this issue Jul 24, 2016
thabti added a commit to thabti/quran.com-frontend that referenced this issue Jul 24, 2016
ahmedre pushed a commit that referenced this issue Jul 24, 2016
* closes #398 - "Previous/Next Surah" when reading first/last surah

* clean up

* ensure package.json is similar to master
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants