Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Missing translations for "settings" in nav drawer #595

Closed
umairidris opened this issue Jan 19, 2017 · 2 comments
Closed

Missing translations for "settings" in nav drawer #595

umairidris opened this issue Jan 19, 2017 · 2 comments

Comments

@umairidris
Copy link
Contributor

No description provided.

@mmahalwy
Copy link
Contributor

It's in the settings modal no?

image

@umairidris
Copy link
Contributor Author

Sorry for not being clear, meant the literal settings wrord in the drawer :)

@umairidris umairidris mentioned this issue Jan 20, 2017
Merged
mmahalwy pushed a commit that referenced this issue Jan 20, 2017
@umairidris @mmahalwy
Fixes #595, #601 Add translations for settings in sidebar (#602)
73f8120 
* Add translations for settings in sidebar

* new line

* More translations

* Periods

* Rename settings ids

* Use existing ids which I blindly missed

* Delete ids from ur.js

* Delete ids from en.js

* Fix reciters title for ur/ar

* Use setting.title

* I should get some sleep

* Revert setting.title to nav.settings

* Remove setting.option, add nav.title
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmahalwy @umairidris