This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Ensure suggestions is an array and close autocomplete on search #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmahalwy
approved these changes
Oct 12, 2018
|
rebuild |
|
rebuild |
|
Deployed to: http://staging.quran.com:32776 |
|
Deployed to: http://staging.quran.com:32819 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure suggestions is an array and close autocomplete on search
When a search yields no suggestions the backend will produce a malformed response in the form
{"": []}(given that the structure should be[{...result...}, ...]), which causes the front-end to choke. This cleans that up to ensure we always put an array into the redux store. Ideally this would be fixed on the back-end but ensuring an array on the front-end could also be a worth-while addition.Also closes the autocomplete when a search is initiated as a small quality-of-life improvement to the search experience.
Checklist
package-lock.json