This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Sort translation languages list in alphabetical order #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quran.com-frontend into sorting-translations-list * 'sorting-translations-list' of https://github.com/quran/quran.com-frontend: Fixes /issues/79
|
lgtm! |
|
Thanks so much! |
|
Yeah this was fun. @mmahalwy Sad that the CI builds failed. It says "No environment variables set". I'm assuming that's a configuration issue and not a tests failing issue? |
|
@mmahalwy After your lgtm do I merge my own PR? Any other processes to follow? Thanks. |
|
@reshadn it's a problem on my end. your tests are good. And yes, process is to merge your own (for those that have access at least...) |
reshadn
added a commit
that referenced
this pull request
Oct 15, 2015
Sort translation languages list in alphabetical order
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
