#383 Ayah Play Audio + Redux Refactoring (WIP)

[thabti]

Hi,

This will be a slightly fat PR. I am not a fan of the decorators, I will make a suggested change and let me know if you agree. I find wrapping the component in a normal function is much easier for new contributors who probably don't use bleed-edge of ES. Also they have not made it into the official spec. Thoughts?

• Clicking the Play link should play the current ayah.
• Refactoring out decorators
• Hide play in search results

[ahmedre]

Deployed to: http://staging.quran.com:32770

[ahmedre]

Deployed to: http://staging.quran.com:32771

[ahmedre]

Deployed to: http://staging.quran.com:32772

[ahmedre]

Deployed to: http://staging.quran.com:32773

[ahmedre]

Deployed to: http://staging.quran.com:32774

[ahmedre]

Deployed to: http://staging.quran.com:32775

[ahmedre]

Deployed to: http://staging.quran.com:32776

[ahmedre]

Deployed to: http://staging.quran.com:32777

[mmahalwy]

✂️

[mmahalwy]

@sabeurthabti this is awesome mashallah! Thanks for this

re decorators: i do really like how you separated the mapStateToProps methods, should definitely do that myself too. As for decorators, I do see your point about them being bleeding edge. One thing that separating them will benefit us is testability, more specifically see: http://redux.js.org/docs/recipes/WritingTests.html#connected-components

I do see your point but I really do like decorators, so I am torn. I think we should make a call and go with it. What do you think?

[ahmedre]

Deployed to: http://staging.quran.com:32778

[thabti]

@mmahalwy let's discuss it on slack. I am happy with either. For me the main thing is readability.

[ahmedre]

Deployed to: http://staging.quran.com:32779