This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 362
Merged
Fixes 438 #448
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a8f91e1
Fixes 438
mmahalwy 16a21ae
babel cli
mmahalwy c9dc879
pass
mmahalwy 289c39d
tools pass
mmahalwy 0684cc0
Kick
mmahalwy 40f8d78
Docker changes
mmahalwy d5a33e1
kick
mmahalwy 6f3ac0d
changes
mmahalwy 0d94ae5
fix
mmahalwy 36e2a2c
fix
mmahalwy 27a6acf
moved files
mmahalwy 3e5601d
fix
mmahalwy f1b4835
fix
mmahalwy bf0867a
moved files
mmahalwy d58117f
eslint
mmahalwy 6ae258b
silly me
mmahalwy 8ff5ffe
fix
mmahalwy e61906b
fixed dev
mmahalwy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
require('dotenv').load(); | ||
require('app-module-path').addPath(__dirname); | ||
require('app-module-path').addPath('./src'); | ||
|
||
var path = require('path'); | ||
var rootDir = path.resolve(__dirname, '../dist'); | ||
|
||
global.__CLIENT__ = false; | ||
global.__SERVER__ = true; | ||
global.__DEVELOPMENT__ = process.env.NODE_ENV !== 'production'; | ||
|
||
var webpackIsomorphicTools = require('webpack-isomorphic-tools'); | ||
|
||
global.webpack_isomorphic_tools = new webpackIsomorphicTools(require('./webpack/isomorphic-tools-configuration')) | ||
.development(__DEVELOPMENT__) | ||
.server(rootDir, function() { | ||
require('../dist/server.js')(); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ module.exports = { | |
sourceMapFilename: '[name]-[chunkhash].map.js' | ||
|
||
}, | ||
context: path.resolve(__dirname, '../src'), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. change There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. line 30 - change |
||
devtool: 'cheap-source-map', | ||
debug: false, | ||
target: 'web', | ||
|
@@ -52,7 +53,9 @@ module.exports = { | |
'transform-runtime', | ||
'add-module-exports', | ||
'transform-decorators-legacy', | ||
'transform-react-display-name' | ||
'transform-react-display-name', | ||
"transform-react-inline-elements", | ||
"transform-react-constant-elements" | ||
] | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
var Express = require('express'); | ||
var webpack = require('webpack'); | ||
|
||
var config = require('../src/config'); | ||
var webpackConfig = require('./dev.config'); | ||
var compiler = webpack(webpackConfig); | ||
|
||
var host = config.host || 'localhost'; | ||
var port = (Number(config.port) + 1) || 3001; | ||
var serverOptions = { | ||
contentBase: 'http://' + host + ':' + port, | ||
quiet: true, | ||
noInfo: true, | ||
hot: true, | ||
inline: true, | ||
lazy: false, | ||
publicPath: webpackConfig.output.publicPath, | ||
headers: {'Access-Control-Allow-Origin': '*'}, | ||
stats: {colors: true} | ||
}; | ||
|
||
var app = new Express(); | ||
|
||
app.use(require('webpack-dev-middleware')(compiler, serverOptions)); | ||
app.use(require('webpack-hot-middleware')(compiler)); | ||
|
||
app.listen(port, function onAppListening(err) { | ||
if (err) { | ||
console.error(err); | ||
} else { | ||
console.info('==> 🚧 Webpack development server listening on port %s', port); | ||
} | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to include
--copy-files
to copy over any none js files.http://stackoverflow.com/questions/32642685/babel-cli-copy-nonjs-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-D
does that :)