line-height updated. #553
line-height updated. #553
Conversation
|
Deployed to: http://staging.quran.com:33064 |
|
rebuild |
|
okay i kicked a rebuild so we can take a look at it. Inshallah this solves it! |
|
Deployed to: http://staging.quran.com:33065 |
|
Hmm, that did not work. I think it has something to do with a horizontal and vertical scroll going wrong. |
|
Okay, I think it's something to do with the lazy load component making the scroll + rendering all weird. |
|
Maybe. The repeated word isn't a new element but it is the same word. I checked it in console. Another thing I have noticed is that the markup of surah page and other pages is not semantic. I donno how much that matters for quran.com but I believe it might be reason for small glitches that we have discovered or are yet to be discovered. |
|
okay that did not fix it... |
|
rebuild |
|
Deployed to: http://staging.quran.com:33105 |
This bug can be mixture of various style. It might be present because of
font-weight. I think using percentage for line-height is not good. % are evil in my opinion.This PR aims to solve issue-548.