Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

#568 UI improvements #577

Closed
wants to merge 7 commits into from
Closed

#568 UI improvements #577

wants to merge 7 commits into from

Conversation

mmahalwy
Copy link
Contributor

One of the many things from #568 :)

  • Moved all the TopOptions to the drawer.

@ahmedre
Copy link
Contributor

ahmedre commented Jan 12, 2017

Deployed to: http://staging.quran.com:33132

@naveed-ahmad
Copy link
Contributor

@mmahalwy can you add scrolling for verse dropdown ? http://staging.quran.com:33132/2

Plus I don't like the design :)

@umairidris
Copy link
Contributor

umairidris commented Jan 12, 2017

I originally did not envision things that frequently changed things (such as verse #, reading mode, etc) to go into the nav drawer. I am not sure if this is the best design but would be cool if the global app bar was there and they would dynamically be added there (as icons or dropdowns)

@ahmedre
Copy link
Contributor

ahmedre commented Jan 12, 2017

Deployed to: http://staging.quran.com:33134

@mmahalwy
Copy link
Contributor Author

@naveed-ahmad sounds good. And me too, we need real design eyes to go into this.

@umairidris I think we need to collect more data on what people change frequently. For example, recitequran.com has their options hidden and into a modal. Not sure what's best to do here but I felt like TopOptions is not the best.

@mmahalwy
Copy link
Contributor Author

@umairidris i will work on global nav tomorrow inshallah

@ahmedre
Copy link
Contributor

ahmedre commented Jan 12, 2017

Deployed to: http://staging.quran.com:33135

@mmahalwy
Copy link
Contributor Author

Closing in favor of #583

@mmahalwy mmahalwy deleted the 568-ui-improvements branch January 19, 2017 06:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants