Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Improved time to first paint #599

Merged
merged 1 commit into from
Jan 20, 2017
Merged

Conversation

naveed-ahmad
Copy link
Contributor

@naveed-ahmad naveed-ahmad commented Jan 20, 2017

intl pollyfil should included before our main js, opening pr for testing the impact of moving js into bottom.

@ahmedre
Copy link
Contributor

ahmedre commented Jan 20, 2017

Deployed to: http://staging.quran.com:33176

@@ -79,6 +79,9 @@ const Html = ({ store, component, assets }) => {
{Object.keys(assets.javascript).map((script, i) =>
<script src={assets.javascript[script]} key={i} />
)}
{
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.6.3/css/font-awesome.min.css" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm i thought links should always be in head?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it can be anywhere in page. We can move all no critical css and js to bottom of page to improve rendering

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove font-awesome since I think it's only used in one place

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants