Skip to content
This repository was archived by the owner on Jun 28, 2021. It is now read-only.

Update id.js #620

Merged
merged 1 commit into from
Jan 28, 2017
Merged

Update id.js #620

merged 1 commit into from
Jan 28, 2017

Conversation

habibr
Copy link
Contributor

@habibr habibr commented Jan 25, 2017

Adding and editing indonesian translation.

Adding and editing indonesian translation.
@ahmedre
Copy link
Contributor

ahmedre commented Jan 25, 2017

Deployed to: http://staging.quran.com:32788

@habibr
Copy link
Contributor Author

habibr commented Jan 25, 2017

Why changing language does not work at the staging site? http://staging.quran.com:32788
Or I missed something?

@ahmedre
Copy link
Contributor

ahmedre commented Jan 28, 2017

@naveed-ahmad - any ideas?

@naveed-ahmad
Copy link
Contributor

@ahmedre there was JS break, fixed here: #622

@ahmedre
Copy link
Contributor

ahmedre commented Jan 28, 2017

rebuild

@ahmedre
Copy link
Contributor

ahmedre commented Jan 28, 2017

Deployed to: http://staging.quran.com:32794

@ahmedre
Copy link
Contributor

ahmedre commented Jan 28, 2017

@naveed-ahmad i see it in drop down but changing languages don't work at the moment - maybe because of flux of api v2/v3 - i'll go ahead and accept and merge this.

jazakAllah khairan @habibr

@ahmedre ahmedre merged commit c10a05d into quran:master Jan 28, 2017
@ahmedre
Copy link
Contributor

ahmedre commented Jan 28, 2017

talked to Naveed, looks like it's because we didn't rebase onto his patch, which means insha'Allah staging.quran.com should reflect your changes once it's deployed sometime soon.

@habibr habibr deleted the patch-1 branch January 28, 2017 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants