This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Refactor settings #818
Merged
Refactor settings #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naveed-ahmad
commented
Jun 6, 2017
•
naveed-ahmad
commented
- Load setting from cookies
- Moved all setting related components into setting namespace
|
Deployed to: http://staging.quran.com:32846 |
naveed-ahmad
commented
Jun 9, 2017
| @@ -0,0 +1,30 @@ | |||
| import React, { PropTypes } from 'react'; | |||
There was a problem hiding this comment.
we should move this to common components
There was a problem hiding this comment.
inshallah I will have a look at doing this.
There was a problem hiding this comment.
@naveed-ahmad check https://github.com/quran/common-components/tree/master/src/Toggle
update to quran-components@0.0.75 for the new toggle on common components
There was a problem hiding this comment.
JazakAllah for review and moving this to component @sabeurthabti
|
Deployed to: http://staging.quran.com:32852 |
|
Deployed to: http://staging.quran.com:32853 |
thabti
reviewed
Jun 10, 2017
| onOptionChange={setOption} | ||
| /> | ||
| </Menu> | ||
| <Settings chapter={chapter} versesIds={versesIds} /> |
thabti
approved these changes
Jun 10, 2017
|
Deployed to: http://staging.quran.com:32858 |
|
Deployed to: http://staging.quran.com:32859 |
|
Deployed to: http://staging.quran.com:32860 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.