This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Fixed an issue that was causing the wrong word to highlight #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebuild |
1 similar comment
|
rebuild |
|
Deployed to: http://staging.quran.com:32889 |
|
Deployed to: http://staging.quran.com:32891 |
naveed-ahmad
approved these changes
Jun 24, 2017
|
Jazak Allah kharain for PR |
|
No problem inshallah more coming soon! |
|
@iMoe037 so so awesome! Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to issue #825
The issue was the element id's were being appended with the audio position number. Each time a line component is rendered the audioPosition goes back to 1 giving the same ids on multiple lines.
To fix this instead of using audioPosition, appended the word.position on line 26. The words are now highlighted in sequential order, although the audio and highlighting are not in sync (another bug?).
I only changed the end of line 72. The pre commit hook or something else must have changed line 71 to span multiple lines.