Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Events constants and logging #877

Merged
merged 3 commits into from
Oct 13, 2017
Merged

Events constants and logging #877

merged 3 commits into from
Oct 13, 2017

Conversation

mmahalwy
Copy link
Contributor

@mmahalwy mmahalwy commented Oct 13, 2017

This is a way to standardize the way we log events and name them. As noted in the file:

The goal for developers is to have them call:

FOOTER_EVENTS.CLICK.AUDIO;

and returns

{ NAME: 'Footer', ACTION: 'Click', LABEL: 'Audio' }

Better yet, calling

FOOTER_EVENTS.CLICK.AUDIO.PROPS;

will give you all the props needed for react-metrics to pass the correct data to google analytics.

@ahmedre
Copy link
Contributor

ahmedre commented Oct 13, 2017

Deployed to: http://staging.quran.com:32965

Copy link
Contributor

@naveed-ahmad naveed-ahmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we can better organize events into respected site components. For example:

Verse: [Copy, Quick Link, Play, Media]
Chapter: [...]
Footer: [...]

Also, we should track Reciters, no idea for now which is most listened Qari or most read translation.

@mmahalwy
Copy link
Contributor Author

rebuild

@mmahalwy
Copy link
Contributor Author

@naveed-ahmad I am organizing based off of GA's hierarchy. Agreed about reciters. PR to follow

@ahmedre
Copy link
Contributor

ahmedre commented Oct 13, 2017

Deployed to: http://staging.quran.com:32966

@mmahalwy mmahalwy merged commit 9866af5 into master Oct 13, 2017
@mmahalwy mmahalwy deleted the events-constants-and-logging branch October 13, 2017 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants