Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

fixed translation #901

Merged
merged 2 commits into from
Nov 29, 2017
Merged

fixed translation #901

merged 2 commits into from
Nov 29, 2017

Conversation

naveed-ahmad
Copy link
Contributor

@naveed-ahmad naveed-ahmad commented Nov 29, 2017 •
edited
Loading

Fixed translation rendering

Translation with footnote could have html as well, this isn't user generated data so xss isn't possible.

Checklist

  • Unit tests written
  • Manually tested
  • New dependencies were added with yarn
  • Prettier & ESLint were run

Screenshot

2017-11-29_0515

@ahmedre
Copy link
Contributor

ahmedre commented Nov 29, 2017

Deployed to: http://staging.quran.com:32881

@ahmedre
Copy link
Contributor

ahmedre commented Nov 29, 2017

Deployed to: http://staging.quran.com:32883

@naveed-ahmad
Copy link
Contributor Author

Looks good!

@naveed-ahmad naveed-ahmad merged commit 257efda into master Nov 29, 2017
@naveed-ahmad naveed-ahmad deleted the translation_text branch November 29, 2017 17:55
@snyk-bot snyk-bot mentioned this pull request Jan 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Dec 29, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmahalwy mmahalwy Awaiting requested review from mmahalwy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naveed-ahmad @ahmedre