Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to work around a Lollipop Compose crash #2182

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Feb 4, 2023

On Lollipop/MR1, there are cases where Compose crashes. While this is
reported on the issue tracker, there is no fix yet. This patch attempts
to sidestep this issue by forcing LTR for the app's Comopsables.

On Lollipop/MR1, there are cases where Compose crashes. While this is
reported on the issue tracker, there is no fix yet. This patch attempts
to sidestep this issue by forcing LTR for the app's Comopsables.
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │  11.7 MiB │  11.7 MiB │ +551 B │  29.7 MiB │  29.7 MiB │ +1.8 KiB 
     arsc │   1.9 MiB │   1.9 MiB │    0 B │   1.9 MiB │   1.9 MiB │      0 B 
 manifest │   5.8 KiB │   5.8 KiB │    0 B │  28.6 KiB │  28.6 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │    0 B │   1.8 MiB │   1.8 MiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │    0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 181.6 KiB │ 181.6 KiB │   -3 B │ 365.5 KiB │ 365.5 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  15.8 MiB │  15.8 MiB │ +548 B │  34.4 MiB │  34.4 MiB │ +1.8 KiB 


@ahmedre ahmedre merged commit 20ea08f into master Feb 4, 2023
@ahmedre ahmedre deleted the workraround_lollipop_crash branch February 4, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant