Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit audio playback events via audio repository #2543

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Jan 13, 2024

Previously, audio events were either broadcast via a local broadcast
(now deprecated), or emitted via an AudioEventPresenter. This replaces
both approaches, and rather than just emitting the current playing ayah,
it emits the entire playback state instead.

Previously, audio events were either broadcast via a local broadcast
(now deprecated), or emitted via an AudioEventPresenter. This replaces
both approaches, and rather than just emitting the current playing ayah,
it emits the entire playback state instead.
Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  12.6 MiB │  12.6 MiB │ +2.7 KiB │    32 MiB │  32.1 MiB │ +5.9 KiB 
     arsc │   2.2 MiB │   2.2 MiB │      0 B │   2.2 MiB │   2.2 MiB │      0 B 
 manifest │   5.6 KiB │   5.6 KiB │      0 B │  27.1 KiB │  27.1 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │      0 B │   1.8 MiB │   1.8 MiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 189.2 KiB │ 189.2 KiB │    -11 B │ 387.5 KiB │ 387.5 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │    17 MiB │    17 MiB │ +2.7 KiB │  37.1 MiB │  37.1 MiB │ +5.9 KiB 


@ahmedre ahmedre merged commit 4239955 into master Jan 13, 2024
4 checks passed
@ahmedre ahmedre deleted the audio_repository branch January 13, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant