-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Android Auto Support #2891
Conversation
cc @jibraniqbal666 please take a look. some notes - on both of our branches, audio doesn't play back for me in the Android Auto OS version. |
|
New Dependencies |
tested - notes:
|
7808a9f
to
86184b2
Compare
Blockers
Nice to Have
|
|
New Dependencies |
How did you debug the normal Android Auto? Is there emulator? I would like to fix these issue :))) |
Which emulator are you using for Android Auto OS, or is it real device? |
I actually have an Android Auto device so I was able to test on a real device - however, I was planning on testing the emulator also for vanilla Android auto - I found this - tldr you launch the Android Auto OS emulator, and then you launch a vanilla Android emulator and install Android Auto on it and connect them. |
86184b2
to
01cf474
Compare
|
New Dependencies |
01cf474
to
db20edb
Compare
|
New Dependencies Upgraded Dependencies |
db20edb
to
b03f7cd
Compare
|
New Dependencies Upgraded Dependencies |
Al7amdulillah, I just migrated the auto stuff to media3, which simplifies a lot of things - it does a lot of the ordinary things for us (handling playback, pause, updating the time, next, previous, ... - things you were doing manually before). This one I tested using the method from the Stackoverflow post linked above for testing and it works (whereas the version before that didn't work) - and this one also works on an actual Android Auto device. It doesn't show the grid view anymore, but can take a look at that in the future in sha' Allah. Presumably, I think I can also make it support all the Qaris in an efficient way in sha' Allah, but need to give it a shot. I also didn't test the standalone Android Automotive app yet, but not really too concerned about that one since I am more interested in Android Auto support (anyone with an Android phone + a device that supports Android Auto + the Android Auto app) rather than Android Automotive support (a completely separate app, needs an Android Automotive device, etc). For what it's worth, I am ok adding Exoplayer, since I've wanted to migrate to Exoplayer instead of MediaPlayer for some time (even had a local branch from a long time ago doing so), so I think moving forward, in sha' Allah, some of this stuff can actually replace some of the existing app audio service stuff as well in sha' Allah. |
|
New Dependencies Upgraded Dependencies |
This patch builds on #2648, and makes a few changes - namely:
The "vanilla Android auto" ships with the APK and is available on devices that use Android auto on the phone. The "autoquran" one is based on the "autoquran" target (instead of app) and is a completely separate apk for Android Auto OS devices.