This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
improve description #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarify: - what levels are re-ordered (`ReadingOrder` unaffected/unrelated) - textual consistency is only the trigger, not the driver - coordinate-based order respects annotation
|
It seems we were doing similiar things at the same time :) |
Apart from your grammar fix, I did use the latest version. I thought this was the best way to express my request. |
|
I'm not super excited about using underscores in the repo name and then using no underscores in the name of the binary, but it does seem to be the convention, so it's merged :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikegerber I tried to be more specific/detailed, because one really must understand the exact use-case.
As for the tool json, I removed step
"layout/segmentation/region"because this does not change region ordering (which is also why it does not affect or relate toReadingOrder), and replaced the underscores with hyphens as is more conventional. (But the tool could probably by namedocrd-repair-ordering.)Feel free to c&p as you like.
I still think this would make a very good addition to
ocrd-segment-repair...