Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for Qfep analysis tool #1

Merged
merged 3 commits into from
Nov 19, 2017
Merged

Hotfix for Qfep analysis tool #1

merged 3 commits into from
Nov 19, 2017

Conversation

acmnpv
Copy link
Contributor

@acmnpv acmnpv commented Sep 19, 2017

Was missing fix from old version to use of different number of
off-diagonal elements. Added now

Was missing fix from old version to use of different number of
off-diagonal elements. Added now
Copy link

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revise, I noticed some nnoffd-s in there (line 496).
There's also some hardcoded numbers in around that area (495-498) that were fixed in q5 already.

Fixed the remaining issues from previous fix.
@acmnpv
Copy link
Contributor Author

acmnpv commented Nov 16, 2017

Made the requested changes. Should be fine now.

Copy link

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed a 4.0_prec on line 495

@mpurg
Copy link

mpurg commented Nov 16, 2017

I will write up a test for this tomorrow.

@mpurg mpurg merged commit 0670be6 into master Nov 19, 2017
@mpurg mpurg deleted the hotfix branch November 19, 2017 12:14
@mpurg
Copy link

mpurg commented Nov 19, 2017

asdasdasd.zip

Here's the test.

@esguerra
Copy link
Member

Nice!
How did you come across the struct module?
I didn't know it.
How not to love python darn it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants