New features in Qt 5.10

[The-Compiler]

Some new Qt 5.10 features related to qutebrowser:

• QtWebEngine
  • Support for window.focus() (doesn't seem to work)
  • New HideScrollbars setting - with that, we should also be able to only inject the stylesheet code when an user stylesheet is actually set. (not going to do this as it also hides scrollbars with multiple scrollable div's)
  • New DesktopVideoCapture and DesktopAudioVideoCapture permissions
    • Though it might be possible to support it in earlier Qt versions too?
  • Support to pause downloads: Pause download feature #1547
  • New QWebEnginePage.download: Use QtWebEngine network stack for all downloads #2328
  • FocusOnNavigationEnabled default will change
  • Also, Qt 5.5 added a MouseLock permission which I apparently missed. (Split off to Add MouseLock permission #3287)
  • QTWEBENGINE_DICTIONARIES_PATH (cc @elshize): Install dictionaries to standarddir.data() on Qt >= 5.10 #3759
• New QProcess::startDetached - not actually useful for what qutebrowser does.
• Check whether Wayland support works better (QtWebEngine and Wayland #2932)
• HTTP/2 might be stable enough to turn on for QtWebKit: HTTP/2 with QtWebKit #2657
• Nouveau should be automatically blacklisted now

[laurynas-karvelis]

I'd say keep the browser simple and less intrusive to people. If I want to use spyware, I just open Chromium. On the other hand, qutebrowser is like first love, it always stays pure and untouched. My two cents are to add config settings to optionally enable such features as DesktopVideo(Audio)Capture/MouseLock etc as enable-able only.

KISS & Suckless! Look at dwm, it's a gem. Right now, qutebrowser is like that.

[The-Compiler]

Like the other permissions already, those will probably have a setting you can set to true/false/ask, with the default being ask.

[rnhmjoj]

So, about the spell check dictionaries... I have some free time and I'm willing to do it.
How would you keep compatibility with older Qt version? Use XDG_DATA_HOME if Qt is 5.10 and fallback to the system path otherwise?

Another issue I have found: the script calls imports browser.webengine.spell and then calls qutebrowser.utils.standarddir which not initialized, so I had to "manually" read the environment to get the path.

[The-Compiler]

I opened #3759 for QTWEBENGINE_DICTIONARIES_PATH - let's continue this there 😉

[The-Compiler]

Tried window.focus() support, but it doesn't seem to work properly:

diff --git a/doc/help/settings.asciidoc b/doc/help/settings.asciidoc
index 3479f7301..7feb70426 100644
--- a/doc/help/settings.asciidoc
+++ b/doc/help/settings.asciidoc
@@ -133,6 +133,7 @@
 |<<content.javascript.alert,content.javascript.alert>>|Show javascript alerts.
 |<<content.javascript.can_access_clipboard,content.javascript.can_access_clipboard>>|Allow JavaScript to read from or write to the clipboard.
 |<<content.javascript.can_close_tabs,content.javascript.can_close_tabs>>|Allow JavaScript to close tabs.
+|<<content.javascript.can_focus_window,content.javascript.can_focus_window>>|Allow JavaScript to focus the window.
 |<<content.javascript.can_open_tabs_automatically,content.javascript.can_open_tabs_automatically>>|Allow JavaScript to open new tabs without user interaction.
 |<<content.javascript.enabled,content.javascript.enabled>>|Enable JavaScript.
 |<<content.javascript.log,content.javascript.log>>|Log levels to use for JavaScript console logging messages.
@@ -1745,6 +1746,18 @@ Default: +pass:[false]+
 
 This setting is only available with the QtWebKit backend.
 
+[[content.javascript.can_focus_window]]
+=== content.javascript.can_focus_window
+Allow JavaScript to focus the window.
+
+Type: <<types,Bool>>
+
+Default: +pass:[false]+
+
+On QtWebEngine, this setting requires Qt 5.10 or newer.
+
+On QtWebKit, this setting is unavailable.
+
 [[content.javascript.can_open_tabs_automatically]]
 === content.javascript.can_open_tabs_automatically
 Allow JavaScript to open new tabs without user interaction.
diff --git a/qutebrowser/browser/webengine/webenginesettings.py b/qutebrowser/browser/webengine/webenginesettings.py
index 2c44684e8..bd93ea50d 100644
--- a/qutebrowser/browser/webengine/webenginesettings.py
+++ b/qutebrowser/browser/webengine/webenginesettings.py
@@ -163,6 +163,9 @@ class WebEngineSettings(websettings.AbstractSettings):
             # Qt 5.8
             'content.print_element_backgrounds':
                 ('PrintElementBackgrounds', None),
+            # Qt 5.10
+            'content.javascript.can_focus_window':
+                ('AllowWindowActivationFromJavaScript', None),
             # Qt 5.11
             'content.autoplay':
                 ('PlaybackRequiresUserGesture', lambda val: not val),
diff --git a/qutebrowser/config/configdata.yml b/qutebrowser/config/configdata.yml
index a137489fd..0a23e7015 100644
--- a/qutebrowser/config/configdata.yml
+++ b/qutebrowser/config/configdata.yml
@@ -511,6 +511,14 @@ content.javascript.can_close_tabs:
   supports_pattern: true
   desc: Allow JavaScript to close tabs.
 
+content.javascript.can_focus_window:
+  default: false
+  type: Bool
+  backend:
+    QtWebKit: false
+    QtWebEngine: Qt 5.10
+  desc: Allow JavaScript to focus the window.
+
 content.javascript.can_open_tabs_automatically:
   default: false
   type: Bool

dropping it for now, which means everything here is either done or split into another issue.