fix _eigs_jaxarray to be compatible with jit #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericgig
reviewed
Jun 12, 2024
|
@Ericgig I have made some changes, please have a look. As far as I tested this way we can work around |
Ericgig
reviewed
Jun 12, 2024
|
@Ericgig You are right I missed that |
Ericgig
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Now can eigs_jaxarray itself be jit if so let's move the jit from _eigs_jaxarray to there.
We use jnp.complex128 for data. Not jnp.complex64 causing the tests to fail.
How about astype(data.dtype)? This would be future proof if we decide to support both types.
|
Look good. |
|
@Ericgig I have added the suggested changes and the required tests are now passing. |
|
Yes, it works. @Ericgig |
|
Could you add/modify a test for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Description
This PR is in an effort to enable jax.jit with qutip.core.metrics and entropy. It fixes _eigs_jaxarray to be compatible with jax.jit.
##Result
With this change trace_dist works with jax.jit